Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage #16

Closed
wants to merge 2 commits into from
Closed

Fix usage #16

wants to merge 2 commits into from

Conversation

JoeScho
Copy link
Owner

@JoeScho JoeScho commented Feb 21, 2020 •
edited
Loading

Background

  • Versions to 1.0.5
  • Bump version of @hapi/joi used in tests
  • Update README.md to reflect accurate usage of @hapi/joi
  • Fix vulnerabilities

Issue

#13

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • The build is passing
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Version

Using Semver versioning, what version number should be bumped for this change?

  • Major
  • Minor
  • Patch

@JoeScho
Copy link
Owner Author

JoeScho commented Feb 21, 2020

Depends on tlivings/enjoi#84

@JoeScho JoeScho closed this May 7, 2020
@JoeScho JoeScho deleted the fix-usage branch May 7, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoeScho