Storage/STG94 Add Queues bearer challenge test case (Azure#5556)

* Add test for queue bearer challenge * update test case * update var name * update test case * fix clang format
Jinming-Hu · Apr 25, 2024 · fc126c4 · fc126c4
1 parent b1286f5
commit fc126c4
Show file tree

Hide file tree

Showing 2 changed files with 70 additions and 1 deletion.
diff --git a/sdk/storage/assets.json b/sdk/storage/assets.json
@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "cpp",
   "TagPrefix": "cpp/storage",
-  "Tag": "cpp/storage_ff69c43232"
+  "Tag": "cpp/storage_94115793d6"
 }
diff --git a/sdk/storage/azure-storage-queues/test/ut/queue_service_client_test.cpp b/sdk/storage/azure-storage-queues/test/ut/queue_service_client_test.cpp
@@ -342,4 +342,73 @@ namespace Azure { namespace Storage { namespace Test {
         = Queues::QueueServiceClient(m_queueServiceClient->GetUrl(), credential, clientOptions);
     EXPECT_THROW(queueServiceClient.GetProperties(), StorageException);
   }
+
+  TEST_F(QueueServiceClientTest, BearerChallengeWorks)
+  {
+    auto clientOptions = InitStorageClientOptions<Queues::QueueClientOptions>();
+    auto options = InitStorageClientOptions<Azure::Identity::ClientSecretCredentialOptions>();
+
+    // With tenantId
+    clientOptions.EnableTenantDiscovery = true;
+    options.AdditionallyAllowedTenants = {"*"};
+    auto queueServiceClient = Queues::QueueServiceClient(
+        m_queueServiceClient->GetUrl(),
+        std::make_shared<Azure::Identity::ClientSecretCredential>(
+            AadTenantId(), AadClientId(), AadClientSecret(), options),
+        clientOptions);
+    EXPECT_NO_THROW(queueServiceClient.GetProperties());
+
+    // Without tenantId
+    clientOptions.EnableTenantDiscovery = true;
+    options.AdditionallyAllowedTenants = {"*"};
+    queueServiceClient = Queues::QueueServiceClient(
+        m_queueServiceClient->GetUrl(),
+        std::make_shared<Azure::Identity::ClientSecretCredential>(
+            "", AadClientId(), AadClientSecret(), options),
+        clientOptions);
+    EXPECT_NO_THROW(queueServiceClient.GetProperties());
+
+    // With custom audience
+    auto queueUrl = Azure::Core::Url(m_queueServiceClient->GetUrl());
+    clientOptions.Audience
+        = Queues::QueueAudience(queueUrl.GetScheme() + "://" + queueUrl.GetHost());
+    queueServiceClient = Queues::QueueServiceClient(
+        m_queueServiceClient->GetUrl(),
+        std::make_shared<Azure::Identity::ClientSecretCredential>(
+            "", AadClientId(), AadClientSecret(), options),
+        clientOptions);
+    EXPECT_NO_THROW(queueServiceClient.GetProperties());
+    clientOptions.Audience.Reset();
+
+    // With error tenantId
+    clientOptions.EnableTenantDiscovery = true;
+    options.AdditionallyAllowedTenants = {"*"};
+    queueServiceClient = Queues::QueueServiceClient(
+        m_queueServiceClient->GetUrl(),
+        std::make_shared<Azure::Identity::ClientSecretCredential>(
+            "test", AadClientId(), AadClientSecret(), options),
+        clientOptions);
+    EXPECT_NO_THROW(queueServiceClient.GetProperties());
+
+    // Disable Tenant Discovery and without tenantId
+    clientOptions.EnableTenantDiscovery = false;
+    queueServiceClient = Queues::QueueServiceClient(
+        m_queueServiceClient->GetUrl(),
+        std::make_shared<Azure::Identity::ClientSecretCredential>(
+            "", AadClientId(), AadClientSecret(), options),
+        clientOptions);
+    EXPECT_THROW(
+        queueServiceClient.GetProperties(), Azure::Core::Credentials::AuthenticationException);
+
+    // Don't allow additional tenants
+    clientOptions.EnableTenantDiscovery = true;
+    options.AdditionallyAllowedTenants = {};
+    queueServiceClient = Queues::QueueServiceClient(
+        m_queueServiceClient->GetUrl(),
+        std::make_shared<Azure::Identity::ClientSecretCredential>(
+            "", AadClientId(), AadClientSecret(), options),
+        clientOptions);
+    EXPECT_THROW(
+        queueServiceClient.GetProperties(), Azure::Core::Credentials::AuthenticationException);
+  }
 }}} // namespace Azure::Storage::Test