Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a dummy top inventory if view-only #226

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

Jikoo
Copy link
Owner

@Jikoo Jikoo commented Jul 14, 2024

Theoretically sorting plugins might clobber real inventories with the "empty" copy, so just reject all plugin interaction.

May be a good idea to drop all added items at the viewer, because the only source theoretically would be their own inventory.
Locking down the bottom inventory isn't really an option; plugins checking the bottom are liable to use viewer's inventory directly instead of obtaining bottom inventory.

Theoretically sorting plugins might clobber inventories with the "empty" copy.
@Jikoo Jikoo merged commit bca080b into master Jul 15, 2024
2 checks passed
@Jikoo Jikoo deleted the dev/lock-down-view-only branch July 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant