Split backend tests & client build #259
Conversation
WalkthroughThe GitHub Actions workflow for a Laravel project has been updated. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/laravel.yml (3 hunks)
Additional comments: 2
.github/workflows/laravel.yml (2)
9-12: The renaming of the
testsjob tobackend_testsis clear and aligns with the PR objectives to distinguish backend tests from other jobs.175-176: The update to the
production-deployjob's dependencies to include bothbackend_testsandbuild_clientis correct and aligns with the PR objectives to ensure both jobs pass before deployment.
| build_client: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| name: Build front-end client | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Get Composer cache directory | ||
| id: composer-cache | ||
| run: | | ||
| echo "::set-output name=dir::$(composer config cache-files-dir)" | ||
|
|
||
| - uses: actions/cache@v2 | ||
| with: | ||
| path: ${{ steps.composer-cache.outputs.dir }} | ||
| key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-composer- | ||
|
|
||
| - uses: actions/cache@v2 | ||
| with: | ||
| path: ~/.npm | ||
| key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-node- | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: ${{ matrix.php }} | ||
| extensions: dom, curl, mbstring, pdo, sqlite, pdo_sqlite | ||
| tools: composer:v2 | ||
| coverage: none | ||
|
|
||
| - name: Prepare the environment | ||
| run: cp .env.example .env | ||
|
|
||
| - name: Install composer dependencies | ||
| run: composer install --prefer-dist --no-interaction --no-progress --ignore-platform-reqs --optimize-autoloader | ||
|
|
||
| - name: Directory permissions | ||
| run: chmod -R 777 storage bootstrap/cache |
There was a problem hiding this comment.
The build_client job includes steps for setting up PHP and installing composer dependencies, which may not be necessary for building a front-end client. Verify if these steps are required for the client build process or if they can be removed to optimize the workflow.
To speed things up a bit, build client in another test.
Summary by CodeRabbit
Refactor
backend_testsfor clarity.New Features
build_clientto handle building the front-end client.Chores
production-deployjob to include the newbuild_clientjob as a dependency, ensuring both backend tests and front-end build are completed before deployment.