Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Vue3 Query Builder - Logic Editor #251

Merged
merged 3 commits into from
Dec 1, 2023
Merged

fix: Vue3 Query Builder - Logic Editor #251

merged 3 commits into from
Dec 1, 2023

Conversation

rishi-raj-jain
Copy link
Contributor

@rishi-raj-jain rishi-raj-jain commented Dec 1, 2023 •
edited
Loading

fix #250
/claim #250

@algora-pbc algora-pbc bot mentioned this pull request Dec 1, 2023
Closed
@rishi-raj-jain
Copy link
Contributor Author

rishi-raj-jain commented Dec 1, 2023 •
edited
Loading

package: https://www.npmjs.com/package/query-builder-vue-3
repo: https://github.com/rishi-raj-jain/query-builder-vue-3
Screenshot 2023-12-02 at 1 58 27 AM

@rishi-raj-jain
Copy link
Contributor Author

recording of the same that it works 👇🏻

Screen.Recording.2023-12-02.at.1.47.54.AM.mp4

@rishi-raj-jain
Copy link
Contributor Author

rishi-raj-jain commented Dec 1, 2023 •
edited
Loading

In case you want to test it, do the following:

checkout to the PR
rm -rf node_modules
npm install
npm run dev

@rishi-raj-jain
Copy link
Contributor Author

Btw, I should say it here explicitly I think, I am more than happy to split the bounty with @kwesterfeld2 for their work.

@rishi-raj-jain
Copy link
Contributor Author

rishi-raj-jain commented Dec 1, 2023 •
edited
Loading

@JhumanJ ready for your review.

@JhumanJ
Copy link
Owner

JhumanJ commented Dec 1, 2023

Thanks for that! I think it's fair to split with @kwesterfeld2!
Can you please check the tests? Although it's working locally for me, pipeline is broken @rishi-raj-jain

@rishi-raj-jain
Copy link
Contributor Author

Can you please check the tests? Although it's working locally for me, pipeline is broken @rishi-raj-jain

All should be good now.

@JhumanJ JhumanJ merged commit dcd4b03 into JhumanJ:vue-3 Dec 1, 2023
3 checks passed
JhumanJ added a commit that referenced this pull request Jan 15, 2024
@JhumanJ @formsdev @chiragchhatrala
Migrate front-end to Nuxt app (#284)
0adce5a 
* wip

* Managed to load a page

* Stuck at changing routes

* Fixed the router, and editable div

* WIP

* Fix app loader

* WIP

* Fix check-auth middleware

* Started to refactor input components

* WIP

* Added select input, v-click-outside for vselect

* update vselect & phone input

* Fixed the mixin

* input component updates

* Fix signature input import

* input component updates in vue3

* image input in vue3

* small fixes

* fix useFormInput watcher

* scale input in vue3

* Vue3: migrating from vuex to Pinia (#249)

* Vue3: migrating from vuex to Pinia

* toggle input fixes

* update configureCompat

---------

Co-authored-by: Forms Dev <[email protected]>

* support vue3 query builder

* Refactor inpus

* fix: Vue3 Query Builder - Logic Editor (#251)

* support vue3 query builder

* upgrade

* remove local from middleware

* Submission table pagination & migrate chart to vue3 (#254)

* Submission table Pagination in background

* migrate chart to vue3

* Form submissions pagination

* Form submissions

* Fix form starts

* Fix openSelect key issue

---------

Co-authored-by: Forms Dev <[email protected]>
Co-authored-by: Julien Nahum <[email protected]>

* Vue 3 better animation (#257)

* vue-3-better-animation

* Working on migration to vueuse/motion

* Form sidebar animations

* Clean code

* Added animations for modal

* Finished implementing better animations

---------

Co-authored-by: Forms Dev <[email protected]>

* Work in progress

* Migrating amplitude and crisp plugin/composable

* Started to refactor pages

* WIP

* vue3-scroll-shadow-fixes (#260)

* WIP

* WIP

* WIP

* Figured out auth & middlewares

* WI

* Refactoring stores and templates pages to comp. api

* Finishing the templates pages

* fix collapsible

* Finish reworking most templates pages

* Reworked workspaces store

* Working on home page and modal

* Fix dropdown

* Fix modal

* Fixed form creation

* Fixed most of the form/show pages

* Updated cors dependency

* fix custom domain warning

* NuxtLink migration (#262)

Co-authored-by: Forms Dev <[email protected]>

* Tiny fixes + start pre-rendering

* migrate-to-nuxt-useappconfig (#263)

* migrate-to-nuxt-useappconfig

* defineAppConfig

---------

Co-authored-by: Forms Dev <[email protected]>

* Working on form/show and editor

* Globally import form inputs to fix resolve

* Remove vform - working on form public page

* Remove initform mixin

* Work in progress for form create guess user

* Nuxt Migration notifications (#265)

* Nuxt Migration notifications

* @input to @update:model-value

* change field type fixes

* @update:model-value

* Enable form-block-logic-editor

* vue-confetti migration

* PR request changes

* useAlert in setup

* Migrate to nuxt settings page AND remove axios (#266)

* Settings pages migration

* remove axios and use opnFetch

* Make created form reactive (#267)

* Remove verify pages and axios lib

---------

Co-authored-by: Julien Nahum <[email protected]>

* Fix alert styling + bug fixes and cleaning

* Refactor notifications + add shadow

* Fix vselect issue

* Working on page pre-rendering

* Created NotionPages store

* Added sitemap on nuxt side

* Sitemap done, working on aws amplify

* Adding missing module

* Remove axios and commit backend changes to sitemap

* Fix notifications

* fix guestpage editor (#269)

Co-authored-by: Julien Nahum <[email protected]>

* Remove appconfig in favor of runtimeconfig

* Fixed amplitude bugs, and added staging environment

* Added amplify file

* Change basdirectory amplify

* Fix loading bar position

* Fix custom redirect (#273)

* Dirty form handling - nuxt migration (#272)

* SEO meta nuxt migration (#274)

* SEO meta nuxt migration

* Polish seo metas, add defaults for OG and twitter

---------

Co-authored-by: Julien Nahum <[email protected]>

* migrate to nuxt useClipboard (#268)

* Set middleware on pages (#278)

* Se middleware on pages

* Se middleware on account page

* add robots.txt (#276)

* 404 page migration (#277)

* Templates pages migration (#275)

* NuxtImg Migration (#279)

Co-authored-by: Julien Nahum <[email protected]>

* Update package json

* Fix build script

* Add loglevel param

* Disable page pre-rendering

* Attempt to allow svgs

* Fix SVGs with NuxtImage

* Add .env file at AWS build time

* tRGIGGER deploy

* Fix issue

* ANother attrempt

* Fix typo

* Fix env?

* Attempt to simplify build

* Enable swr caching instead of prerenderign

* Better image compression

* Last attempt at nuxt images efficiency

* Improve image optimization again

* Remove NuxtImg for non asset files

* Restore templates pages cache

* Remove useless images + fix templates show page

* image optimization caching + fix hydratation issue form template page

* URL generation (front&back) + fixed authJWT for SSR

* Fix composable issue

* Fix form share page

* Embeddable form as a nuxt middleware

* Fix URL for embeddable middleware

* Debugging embeddable on amplify

* Add custom domain support

* No follow for non-production env

* Fix sentry nuxt and custom domain redirect

* remove api prefix from routes (#280)

* remove api prefix from routes

* PR changes

---------

Co-authored-by: Julien Nahum <[email protected]>

* nuxt migration -file upload - WIP (#271)

Co-authored-by: Julien Nahum <[email protected]>

* Fix local file upload

* Fix file submissions preview

* API redirect to back-end from nuxt

* API redirect to back-end from nuxt

* Remove old JS app, update deploy script

* Fix tests, added gh action nuxt step

* Updated package-lock.json

* Setup node in GH Nuxt action

* Setup client directory for GH workflow

---------

Co-authored-by: Forms Dev <[email protected]>
Co-authored-by: Chirag Chhatrala <[email protected]>
Co-authored-by: Rishi Raj Jain <[email protected]>
Co-authored-by: formsdev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JhumanJ JhumanJ JhumanJ approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishi-raj-jain @JhumanJ