register page captcha test cases

JhumanJ · Dec 10, 2024 · c63571e · c63571e
1 parent 7e4b2b7
commit c63571e
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/api/tests/Feature/RegisterTest.php b/api/tests/Feature/RegisterTest.php
@@ -1,22 +1,31 @@
 <?php
 
 use App\Models\User;
+use App\Rules\ValidHCaptcha;
+use Illuminate\Support\Facades\Http;
 
 it('can register', function () {
+
+    Http::fake([
+        ValidHCaptcha::H_CAPTCHA_VERIFY_URL => Http::response(['success' => true])
+    ]);
+
     $this->postJson('/register', [
         'name' => 'Test User',
         'email' => '[email protected]',
         'hear_about_us' => 'google',
         'password' => 'secret',
         'password_confirmation' => 'secret',
         'agree_terms' => true,
+        'h-captcha-response' => 'test-token', // Mock token for testing
     ])
         ->assertSuccessful()
         ->assertJsonStructure(['id', 'name', 'email']);
-    $this->assertDatabaseHas('users', [
-        'name' => 'Test User',
-        'email' => '[email protected]',
-    ]);
+
+    $user = User::where('email', '[email protected]')->first();
+    expect($user)->not->toBeNull();
+    expect($user->meta)->toHaveKey('registration_ip');
+    expect($user->meta['registration_ip'])->toBe(request()->ip());
 });
 
 it('cannot register with existing email', function () {
@@ -27,6 +36,7 @@
         'email' => '[email protected]',
         'password' => 'secret',
         'password_confirmation' => 'secret',
+        'h-captcha-response' => 'test-token',
     ])
         ->assertStatus(422)
         ->assertJsonValidationErrors(['email']);
@@ -48,15 +58,30 @@
         'password' => 'secret',
         'password_confirmation' => 'secret',
         'agree_terms' => true,
+        'h-captcha-response' => 'test-token',
     ])
         ->assertStatus(422)
         ->assertJsonValidationErrors(['email'])
         ->assertJson([
-            'message' => 'Disposable email addresses are not allowed.',
+            'message' => 'Disposable email addresses are not allowed. (and 1 more error)',
             'errors' => [
                 'email' => [
                     'Disposable email addresses are not allowed.',
                 ],
             ],
         ]);
 });
+
+it('requires hcaptcha token in production', function () {
+    app()->detectEnvironment(fn() => 'production');
+
+    $this->postJson('/register', [
+        'name' => 'Test User',
+        'email' => '[email protected]',
+        'hear_about_us' => 'google',
+        'password' => 'secret',
+        'password_confirmation' => 'secret',
+    ])
+        ->assertStatus(422)
+        ->assertJsonValidationErrors(['h-captcha-response']);
+});
diff --git a/api/tests/Feature/UserManagementTest.php b/api/tests/Feature/UserManagementTest.php
@@ -2,10 +2,15 @@
 
 use App\Models\UserInvite;
 use Carbon\Carbon;
+use App\Rules\ValidHCaptcha;
+use Illuminate\Support\Facades\Http;
 
 beforeEach(function () {
     $this->user = $this->actingAsProUser();
     $this->workspace = $this->createUserWorkspace($this->user);
+    Http::fake([
+        ValidHCaptcha::H_CAPTCHA_VERIFY_URL => Http::response(['success' => true])
+    ]);
 });
 
 
@@ -31,6 +36,7 @@
         'password_confirmation' => 'secret',
         'agree_terms' => true,
         'invite_token' => $token,
+        'h-captcha-response' => 'test-token',
     ]);
     $response->assertSuccessful();
     expect($this->workspace->users()->count())->toBe(2);
@@ -59,6 +65,7 @@
         'password_confirmation' => 'secret',
         'agree_terms' => true,
         'invite_token' => $token,
+        'h-captcha-response' => 'test-token',
     ]);
     $response->assertStatus(400)->assertJson([
         'message' => 'Invite token has expired.',
@@ -88,6 +95,7 @@
         'password_confirmation' => 'secret',
         'agree_terms' => true,
         'invite_token' => $token,
+        'h-captcha-response' => 'test-token',
     ]);
     $response->assertSuccessful();
     expect($this->workspace->users()->count())->toBe(2);
@@ -104,6 +112,7 @@
         'password_confirmation' => 'secret',
         'agree_terms' => true,
         'invite_token' => $token,
+        'h-captcha-response' => 'test-token',
     ]);
 
     $response->assertStatus(422)->assertJson([
@@ -138,6 +147,7 @@
         'password_confirmation' => 'secret',
         'agree_terms' => true,
         'invite_token' => $token,
+        'h-captcha-response' => 'test-token',
     ]);
     $response->assertStatus(400)->assertJson([
         'message' => 'Invite token is invalid.',