Refactor part of UserExcludeUpgrades() #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @iTrooz , linting is failing on the PR, can you fix it up? |
|
Done ! |
Jguer
approved these changes
Jun 28, 2024
|
Hey @Jguer any plans to merge ? |
|
Yes, let's do it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey !
I was looking at UserExcludeUpgrades() for another PR, and had great difficulty to understand its code. So I ended up refactoring the function in order to understand it better.
Maybe there was a reason the function was written like that, or I was just not smart enough to understand, but since I've done it, I'm offering this refactor here in case it interests you.