Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 242 Support #183

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Add 242 Support #183

merged 2 commits into from
Jun 19, 2024

Conversation

fscarponi
Copy link
Contributor

@fscarponi fscarponi commented Jun 13, 2024

Done:
Fix project resources for test samples
Created a new kotlin script that allow to patch user/.gradle/caches/idecaches/buildconfig*
Integrate script on GHActions (the script runs of action fail)
TODO:
fix kmp
fix kmp tests

@fscarponi fscarponi marked this pull request as draft June 13, 2024 07:02
@fscarponi fscarponi marked this pull request as ready for review June 13, 2024 15:44
@fscarponi fscarponi force-pushed the fabrizio.scarponi/242 branch 2 times, most recently from ddaced3 to aa82cb7 Compare June 14, 2024 07:36
@fscarponi fscarponi changed the title 242 pipeline test fix - do not merge Add 242 Support Jun 14, 2024
@fscarponi fscarponi marked this pull request as draft June 14, 2024 14:26
@fscarponi fscarponi requested a review from lamba92 June 14, 2024 14:27
The commit updates the version to 242 in `.github/workflows/publish-snapshot.yml.disabled` and `build.gradle.kts` files.
Additionally, new IDE patch policy has been implemented in `.github/workflows/test.yml`, allowing continual tests even on failures. For this, multiple environment variables have been defined and an if clause is introduced to check failure conditions before patching and re-running tests.
Modifications are also made to `SourceSetModel.kt` to handle dependencies slightly differently. The file `kmp-modifier/src/test/kotlin/com/jetbrains/packageSearch/mppDependencyUpdater/intellijStuff/SdkTestCase.kt` has been largely commented out.
@fscarponi fscarponi force-pushed the fabrizio.scarponi/242 branch from 82159b3 to 0dbef8c Compare June 14, 2024 14:36
The test workflow has been updated to trigger only on pull requests to the master branch, removing the previously specified branches. Also, the 'publish-release' and 'build' workflows have been disabled for now.
@fscarponi fscarponi marked this pull request as ready for review June 19, 2024 08:52
@lamba92 lamba92 merged commit 78a3e1a into master Jun 19, 2024
17 of 20 checks passed
@lamba92 lamba92 deleted the fabrizio.scarponi/242 branch June 19, 2024 09:21
@fscarponi fscarponi restored the fabrizio.scarponi/242 branch June 19, 2024 09:22
@fscarponi fscarponi deleted the fabrizio.scarponi/242 branch June 19, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants