Skip to content

Commit

Permalink
Disable packages download UI state in ToolWindowViewModel (#107)
Browse files Browse the repository at this point in the history
The handling for showing packages being downloaded in the ToolWindowViewModel has been deactivated. This was done to mitigate PKGS-1389 issue where the UI did not accurately reflect if packages were downloading or not.

Co-authored-by: Lamberto Basti <[email protected]>
  • Loading branch information
lamba92 and Lamberto Basti authored Feb 28, 2024
1 parent fcd97c7 commit c917125
Showing 1 changed file with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,11 @@ class ToolWindowViewModel(project: Project, private val viewModelScope: Coroutin
isProjectSyncing -> PackageSearchToolWindowState.Loading(
message = easterEggMessage ?: message("packagesearch.toolwindow.loading.syncing")
)

packagesBeingDownloaded -> PackageSearchToolWindowState.Loading(
message = easterEggMessage ?: message("packagesearch.toolwindow.loading.downloading")
)
// Commented to mitigate PKGS-1389 "dowloading packages" UI does not reflect if packages are really being downloaded or not
// https://youtrack.jetbrains.com/issue/PKGS-1389
// packagesBeingDownloaded -> PackageSearchToolWindowState.Loading(
// message = easterEggMessage ?: message("packagesearch.toolwindow.loading.downloading")
// )

else -> PackageSearchToolWindowState.NoModules
}
Expand Down

0 comments on commit c917125

Please sign in to comment.