Bugfix decorated window on windows - clickable components inside title area should work now #731
+35
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea
Place a background composable behind the title content that handles all windows draggable header related stuff. This way, everything inside the title bar is placed on top of the composable that forwards the events to the draggable header.
Issues this solves
when clicking a dropdown menu in the title bar, the popup did not pop up until the next mouse move => fixed
TODO
Box
around the title content, apply the modifier to it instead of the title bar composable and place the title bar composable inside the box with a simplefillMaxSize
Modifier - I'm pretty sure it does not change anything, still, it needs to be tested on mac and linux as well oncecustomTitleBarMouseEventHandler
as well - it may be necessary to use the same fix there? I don't know, I don't have a mac and I don't know if the mac has the same issuescustomTitleBarMouseEventHandler
as is (also because I don't know how it is used on mac) - it may be possible to simplifiy it like following as there is no need to try to detect if we are over a user control or not anymore because of the layerig of the background composable and the content.Fix #368