[REVIEW ONLY] Add slot APIs to GroupHeader #720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Morgillo <[email protected]>
rock3r
reviewed
Dec 9, 2024
| @@ -88,4 +127,4 @@ internal fun Borders() { | |||
| .border(borderAlignment, width, borderColor, RoundedCornerShape(4.dp, 0.dp, 4.dp, 0.dp), expand) | |||
| ) | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Can you restore the empty line at EOF?
There was a problem hiding this comment.
Somewhere over the rainbow 🌈, my settings get lost
| verticalAlignment = Alignment.CenterVertically, | ||
| horizontalArrangement = Arrangement.spacedBy(8.dp), | ||
| ) { | ||
| startComponent?.let { Box(Modifier.size(16.dp)) { it() } } |
There was a problem hiding this comment.
Please don't use let instead of if (thing != null)
Also, we likely need a spacer between the component and the text (same on the end component)
There was a problem hiding this comment.
Nevermind about the spacer, had not noticed the arrangement :)
rock3r
reviewed
Dec 9, 2024
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Empty line at EOF here too :)
Signed-off-by: Ivan Morgillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
20241209-1414-57.3788581.mp4