Format with ktfmt #572
Merged
Format with ktfmt #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure is simply the SARIF CI job not finding a SARIF file since I disabled the task... I'll disable that job for now |
rock3r
added a commit
that referenced
this pull request
Sep 3, 2024
* Format with ktfmt, use ktlint for inspections only * Make ktlint plugin required again, but set to manual * Make ktlint not used for formatting in IDE * Make ktfmt plugin required, used for formatting in IDE * Make pre-push run config use ktfmt * Add ktfmt Gradle plugin * ktfmt uses kotlinlang style both in IDE and Gradle * Upgrade ktfmt Gradle plugin, set style Also sets a minimum version for the ktfmt plugin that supports custom styles, and stores our style. * Make Kotlin and KDoc formatter plugins required * Upgrade kotlinter plugin to latest version * Use ktfmt to reformat project in run config * Add git hook for pre-push to ensure correct formatting * Format with ktfmt (#572) * Reformat everything with ktfmt * Don't nag about ktlint suppressions in .editorconfig * Suppress ktlint checks that clash with ktfmt * Disable MergeSarifTask for now * Disable upload-sarif CI step for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformat the entire project with ktfmt. Does not really need to be reviewed, it's all automatic changes.
The MergeSarif task stopped working for some reason — will be fixed in #573