Add text colours to GlobalColors #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Colors from design POV looks correct to me! Glad this is happening as it has come up recently in Studio to want some of these colors. |
devkanro
approved these changes
May 9, 2024
...lone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/view/markdown/MarkdownPreview.kt
Outdated
Show resolved
Hide resolved
It's practical to have the "base" text colours in GlobalColors: * Normal * Selected * Disabled * Info * Error They apply to labels and most components, but not every component (e.g., default buttons have "inverted" text colors). Note that the text colour is used as content colour, but not directly in the styling. Besides, when initialising the stylings, we can't really read these values as they haven't been init yet. This is mostly a convenience for users that want to set a content colour (e.g., to visually show some text as disabled/error). Note: GlobalColors.paneBackground was renamed to panelBackground for consistency with the Swing color key naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's practical to have the "base" text colours in GlobalColors:
They apply to labels and most components, but not every component (e.g., default buttons have "inverted" text colors).
Note that the text colour is used as content colour, but not directly in the styling. Besides, when initialising the stylings, we can't really read these values as they haven't been init yet.
This is mostly a convenience for users that want to set a content colour (e.g., to visually show some text as disabled/error).
Note: GlobalColors.paneBackground was renamed to panelBackground for consistency with the Swing color key naming.