Fix menu dividers in bridge #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main root cause was a missing return statement in retrieveIntAsDp(), but we also had terribly inconsistent values for the menus compared to the actual appearance. I have tweaked the bridge menu style defaults to align better, but we'll have to come back to revisit the whole menu implementation to actually use the right values in the right way. The current implementation is not satisfactory.
rock3r
added
bug
fscarponi
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main root cause was a missing return statement in retrieveIntAsDp(), but we also had terribly inconsistent values for the menus compared to the actual appearance.
I have tweaked the bridge menu style defaults to align better, but we'll have to come back to revisit the whole menu implementation to actually use the right values in the right way. The current implementation is not satisfactory.
Fixes #358