Diff lines when deciding what blocks to update #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a parameter to not apply optimizations to documents which could be modified. Added workarounds for LinkReferenceDefinition which shouldn't be a top level node.
rock3r
requested changes
Mar 29, 2024
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Show resolved
Hide resolved
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Show resolved
Hide resolved
| import org.junit.Assert.assertEquals | ||
| import org.junit.Test | ||
|
|
||
| class MarkdownProcessorTest { |
There was a problem hiding this comment.
For such a big feature I would expect a ton of tests, can you please add more covering all possile cases?
E.g.:
- First block edited
- Last block edited
- Block in the middle edited
- Blocks merged
- Blocks split
- Blocks deleted
- Blocks added
Etc
obask
added a commit
to obask/jewel
that referenced
this pull request
Mar 29, 2024
rock3r
pushed a commit
that referenced
this pull request
Mar 30, 2024
* Diff lines when deciding what blocks to update Also add a parameter to not apply optimizations to documents which could be modified. Added workarounds for LinkReferenceDefinition which shouldn't be a top level node. * Add more parser tests #335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a parameter to not apply optimizations to documents which could be modified.
Added workarounds for LinkReferenceDefinition which shouldn't be a top level node.