Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging #257

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove logging #257

merged 1 commit into from
Nov 27, 2023

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Nov 27, 2023

Fixes #256

@rock3r rock3r added this to the Milestone 11 — v0.11.0 milestone Nov 27, 2023
@rock3r rock3r requested review from devkanro and fscarponi November 27, 2023 07:41
@rock3r rock3r self-assigned this Nov 27, 2023
devkanro
devkanro approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@devkanro devkanro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When necessary, you can use debugMode to print logs

@rock3r
Copy link
Collaborator Author

rock3r commented Nov 27, 2023

Yes, but it shouldn't be necessary to begin with at this point. Debug logging can be added if/when needed while debugging.

@rock3r rock3r merged commit 4cf1eeb into main Nov 27, 2023
12 checks passed
@rock3r rock3r deleted the remove-logging branch November 27, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devkanro devkanro devkanro approved these changes

@fscarponi fscarponi Awaiting requested review from fscarponi

Assignees

@rock3r rock3r

Labels
None yet
Projects
None yet
Milestone
Milestone 11 — v0.11.0
Development

Successfully merging this pull request may close these issues.

Remove logging from foundation and UI
2 participants
@rock3r @devkanro