Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LazyTable support #253

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

LazyTable support #253

wants to merge 2 commits into from

Conversation

devkanro
Copy link
Collaborator

@devkanro devkanro commented Nov 24, 2023 •
edited
Loading

LazyTable features:

  • Basic table view
  • Lazy cell size
  • Pinned rows and columns
  • ScrollbarAdapter for tables
  • Scrolling with animation
  • Single-selection for cell and row
  • Multi-selection for cells, rows and columns
  • Draggable rows and columns
  • Mergeable cells
  • Styling
  • Code/Performance review

LazyLayout features:

  • Layout logic, available in LazyTable.kt and LazyTableMeasure.kt
  • Scrollable, clipping and overscroll effect, available in LazyTableState.kt#L112 and LazyTableState.kt#L168, clipping supported in LazyTable.kt#L94, overscroll effect supported in LazyTable.kt#L67 but not test yet because it not available in Desktop.
  • Semantics data, not support yet. Because Modifier.lazyLayoutSemantics is internal function.
  • Beyond-bounds, not support yet. LazyLayoutBeyondBoundsModifierLocal is internal, but we should need impl our one, we need support both of the Vertical and Horizontal orientation
  • PinnableContainer, we support pin rows and columns but just impl it in layout logic. We don't use the PinnableContainer because it will case chaos in table layout.
  • Prefetching, not support yet.
  • Animated scroll, we support it fully in LazyTableAnimateScroll.kt#L49, but I copied much code from LazyLayoutAnimateScroll.
  • Scroll position maintenance, we support it fully.
  • Animated place, not support yet and we have no plan to support it. These animations do not fit well with the table layout and may cause confusion.

Needed internal API

Screenshots

2023-11-28.19.39.30.mov
2024-05-14.212646.mp4
Aug.04.1.mov
Aug.04.mov

Closes #61

@devkanro devkanro added feature New feature or request new component A new component to implement labels Nov 24, 2023
@devkanro devkanro self-assigned this Nov 24, 2023
@devkanro devkanro marked this pull request as draft November 24, 2023 18:58
@rock3r rock3r requested review from rock3r and Walingar November 28, 2023 12:00
@rock3r rock3r mentioned this pull request Jan 5, 2024
Open
@devkanro devkanro force-pushed the table branch 2 times, most recently from 4f091ad to 6b96c66 Compare January 10, 2024 09:07
@rock3r rock3r removed the request for review from Walingar August 5, 2024 08:13
@rock3r
Copy link
Collaborator

rock3r commented Nov 18, 2024

@devkanro do you still intend to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rock3r rock3r Awaiting requested review from rock3r

At least 1 approving review is required to merge this pull request.

Assignees

@devkanro devkanro

Labels
feature New feature or request new component A new component to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complex component: LazyTable
2 participants
@devkanro @rock3r