Refactor key-bindings and pointer event handlers and fixed meta pressed on macos #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
approved these changes
Oct 31, 2023
…ed on macos. Key-bindings and pointer event handlers in SelectableLazyColumn and related tree views have been refactored for improved clarity and usability. This includes changes in default keybindings for selectable columns and adjustments in the hierarchical structure of key event handling for better organization and logic flow. Pivotal changes were made in the naming and function calls related to multi-selection and contiguous selection key events.
This commit refactor methods related to KeyEvent in different classes to properties. Operator functions for key event handling were replaced with their equivalent properties, for better clarity and readability. This includes alterations in naming conventions like 'selectParent()' to 'isSelectParent' which are more expressive and intuitive to understand their underlying functionality.
Updated KeyBindingActions interface to KeyActions and renamed methods to properties for improved clarity. This change better conveys what these properties are doing and makes their functionality more intuitive to understand. This encompasses modifications in method names such as 'selectParent()' to 'isSelectParent'.
rock3r
force-pushed
the
lamberto.basti/meta-pressed-macos
branch
from
56b30ab to
3a9eab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key-bindings and pointer event handlers in SelectableLazyColumn and related tree views have been refactored for improved clarity and usability. This includes changes in default keybindings for selectable columns and adjustments in the hierarchical structure of key event handling for better organization and logic flow. Pivotal changes were made in the naming and function calls related to multi-selection and contiguous selection key events.