Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup IDE demo #204

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Cleanup IDE demo #204

merged 1 commit into from
Oct 25, 2023

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Oct 24, 2023

  • Use IconButton (remove todo)
  • Make IconButton behave like Actions that pop up a menu (they stay pressed when the menu is open)
  • Make RightColumn and LeftColumn private as they should

@rock3r rock3r added the feature New feature or request label Oct 24, 2023
@rock3r rock3r requested review from devkanro and Walingar October 24, 2023 16:58
@rock3r rock3r self-assigned this Oct 24, 2023
@rock3r rock3r enabled auto-merge (squash) October 25, 2023 07:04
@rock3r rock3r merged commit 718e9dd into main Oct 25, 2023
10 of 11 checks passed
@rock3r rock3r deleted the cleanup-demo branch October 25, 2023 07:12
rock3r added a commit that referenced this pull request Oct 25, 2023
@rock3r
Cleanup IDE demo (#204)
e486688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devkanro devkanro devkanro approved these changes

@Walingar Walingar Awaiting requested review from Walingar

Assignees

@rock3r rock3r

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rock3r @devkanro