Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old UI buttons look wrong in disabled state in bridge #200

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Oct 23, 2023

Before

image

After

image

The issue was reading the wrong values. Switched to using JBUI more as it's a safer option.

@rock3r rock3r added the consistency Our UI presentation is not consistent with IJ label Oct 23, 2023
@rock3r rock3r added this to the Milestone 8 — v0.8.0 milestone Oct 23, 2023
@rock3r rock3r requested review from devkanro and fscarponi October 23, 2023 09:44
@rock3r rock3r self-assigned this Oct 23, 2023
We were reading the wrong values... took the opportunity to use JBUI as
much as possible for buttons, to be on the safe side.
@rock3r rock3r merged commit e478afd into main Oct 23, 2023
12 checks passed
@rock3r rock3r deleted the old-ui-buttons branch October 23, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Our UI presentation is not consistent with IJ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants