Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IJ 233 with new theming API #169

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Support IJ 233 with new theming API #169

merged 3 commits into from
Oct 11, 2023

Conversation

Walingar
Copy link
Collaborator

@Walingar Walingar commented Oct 11, 2023

This PR splits implementations for 232 and 233, so that in 233 new theming API is used

Fixes: #116
Fixes: #131

* Extract implementation for 232 and 233 in separate modules
* Don't use reflection for introduced API
@Walingar Walingar requested a review from rock3r October 11, 2023 12:54
Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@rock3r rock3r merged commit 3c38511 into main Oct 11, 2023
10 checks passed
@rock3r rock3r deleted the nr/support-233 branch October 11, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IJ 23.3 EAP Replace reflection with public API access
2 participants