Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin demo #163

Merged
merged 24 commits into from
Oct 10, 2023
Merged

New plugin demo #163

merged 24 commits into from
Oct 10, 2023

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Oct 10, 2023

A new, more complex plugin sample that shows the Swing and Compose implementations in parallel.

Notes:

  • Bold fonts don't load for some reason in the Compose sample (see IDE plugin can't access font variants #162)
  • Images in Swing are possibly not loaded/painted the right way, but I don't know a better way to do it
  • Images in Swing are fill-width, whereas in Compose they are fitted to the available space. I'd like a splitter to resize them. Even better would be having a layout breakpoint to change the layout when there is enough room to have the image side-by-side with the text in Compose. I can't be bothered to do it in Swing, it's too much work
  • The image in Compose has a shader applied to it on hover, because I can, but the shader is broken and needs fixing
  • The splitter in Compose has a 1-px-wide drag area, which is obviously not great
  • The Compose selected item is reset when leaving the tab, it should likely be stored in the service instead, but this is good enough for now
  • The tags in the Compose version are clickable and set the filter — can't do that in Swing
  • Tags' text colour is not correct in Swing (it probably gets overridden by virtue of being in a list item renderer) and I can't be bothered to make it work by fighting Swing.

Swing version

image

Compose version

image

rock3r added 24 commits October 10, 2023 12:11
Some data comes from less-than-authoritative sources (i.e., me), and
logos come from The Interwebs™ and Dan's collection (thanks, Dan!).
Had to give up on the image loading at some point, it was just a PITA.
I wanted to also have a placeholder, and less terrible performance, as
now we resize the image all the time, which is obviously bad. I also
wanted the image not to only fit the width but the height too, but that
also was a pain.
...with the classic Swing solution
@rock3r rock3r requested a review from fscarponi October 10, 2023 10:38
@rock3r rock3r merged commit 705513a into main Oct 10, 2023
6 checks passed
@rock3r rock3r deleted the plugin-demo branch October 10, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants