Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include only foundation-desktop in the published library #153

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

Walingar
Copy link
Collaborator

@Walingar Walingar commented Oct 3, 2023

Common layout for Compose for Desktop libraries should be that "library" part depends only on needed foundation/material/ui parts and "sample" part depends on compose.desktop.currentOs, so dependency on skiko runtime will be provided for these samples.

@Walingar Walingar requested a review from rock3r October 3, 2023 17:41
Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rock3r rock3r enabled auto-merge (squash) October 3, 2023 17:58
@rock3r rock3r merged commit b71e94f into main Oct 3, 2023
6 checks passed
@rock3r rock3r deleted the nr/proper-jewel-dependencies-2 branch October 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants