Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various components #123

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Fix various components #123

merged 11 commits into from
Sep 21, 2023

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Sep 21, 2023

This PR fixes a number of issues with various components:

  1. Link
    • Disabled icons look closer to Swing
    • Use focusOutline modifier instead of custom implementation
    • Remove indication — it must always be null
  2. Checkbox
    • Fix outlines size and position to match the SVGs
    • Use global outline size
    • Tweak standalone metric iconTextGap
  3. Radio Button
    • Fix outlines to match the SVGs
  4. Dropdown
    • State mutation was broken (no focus, etc.)
    • Min size and padding are closer to Swing now
    • Focus ring was missing
    • Now we pretend it's focused when the menu is open (like Swing does)
  5. InputField (TextFields and TextAreas)
    • Only show focus outline when undecorated = false

Plus some minor cleanup.

@rock3r rock3r added bug Something isn't working consistency Our UI presentation is not consistent with IJ labels Sep 21, 2023
@rock3r rock3r added this to the Build 0.7.0 (milestone 7) milestone Sep 21, 2023
@rock3r rock3r requested a review from fscarponi September 21, 2023 14:38
@fscarponi fscarponi merged commit b70eac8 into main Sep 21, 2023
6 checks passed
@fscarponi fscarponi deleted the various-fixes branch September 21, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working consistency Our UI presentation is not consistent with IJ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants