Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping #121

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Housekeeping #121

merged 4 commits into from
Sep 21, 2023

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Sep 20, 2023

  • Remove old cruft (darcula modules, compose-utils)
  • Move int-ui to top level (see Drop Darcula-standalone plans #120 — no more standalone Darcula)
  • Update readme to reflect current state
  • Clean up config plugins not to depend on each other

@rock3r rock3r added feature New feature or request api Changes related to the public API labels Sep 20, 2023
@rock3r rock3r added this to the Build 0.7.0 (milestone 7) milestone Sep 20, 2023
@rock3r rock3r requested a review from fscarponi September 20, 2023 15:15
@rock3r rock3r self-assigned this Sep 20, 2023
@rock3r rock3r requested a review from Walingar September 20, 2023 15:18
@rock3r
Copy link
Collaborator Author

rock3r commented Sep 20, 2023

@Walingar any clue why the standalone sample crashes on startup with:

org.jetbrains.skiko.LibraryLoadException: Cannot find libskiko-macos-arm64.dylib.sha256, proper native dependency missing.
	at org.jetbrains.skiko.Library.findAndLoad(Library.kt:105)
	at org.jetbrains.skiko.Library.load(Library.kt:59)
	at org.jetbrains.skia.impl.Library$Companion.staticLoad(Library.jvm.kt:12)
	at org.jetbrains.skia.Data.<clinit>(Data.kt:60)
	... 5 more

While the IDE sample works fine?

@rock3r rock3r marked this pull request as ready for review September 20, 2023 15:45
@rock3r
Copy link
Collaborator Author

rock3r commented Sep 20, 2023

All fixed, thanks to @Walingar 🤟

@rock3r rock3r merged commit 9f755f5 into main Sep 21, 2023
6 checks passed
@rock3r rock3r deleted the housekeeping branch September 21, 2023 08:39
@rock3r rock3r mentioned this pull request Sep 21, 2023
Closed
@rock3r rock3r linked an issue Sep 21, 2023 that may be closed by this pull request
Update and clean up docs (draft) #56
Closed
@rock3r rock3r mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Walingar Walingar Walingar approved these changes

@fscarponi fscarponi Awaiting requested review from fscarponi

Assignees

@rock3r rock3r

Labels
api Changes related to the public API feature New feature or request
Projects
None yet
Milestone
Build 0.7.0 (milestone 7)
Development

Successfully merging this pull request may close these issues.

Update and clean up docs (draft)
2 participants
@rock3r @Walingar