Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine 'addComposeTab' to include closeable option #118

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Refine 'addComposeTab' to include closeable option #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/ComposePanel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ import com.intellij.openapi.wm.ToolWindow
fun ToolWindow.addComposeTab(
tabDisplayName: String,
isLockable: Boolean = true,
isCloseable: Boolean = false,
content: @Composable () -> Unit,
) = ComposePanel()
.apply { setContent(content) }
.also { contentManager.addContent(contentManager.factory.createContent(it, tabDisplayName, isLockable)) }
) {
System.setProperty("compose.swing.render.on.graphics", "true")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF why is this here

val composePanel = ComposePanel()
composePanel.setContent(content)
val tabContent = contentManager.factory.createContent(composePanel, tabDisplayName, isLockable)
tabContent.isCloseable = isCloseable
contentManager.addContent(tabContent)
}