Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial-monitor: Support LF line-ending mode and fix split-up line-endings #894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Crementif
Copy link

@Crementif Crementif commented Jul 29, 2023

Description

I was working with a serial interface platform that uses LF-only line endings so the received data would output to a single line. This addresses that, alongside an existing issue with how it deals with line-endings that are split between chunks.

What this fixes

This commit adds LF ("\n") line ending support, completing coverage for all line endings ("\r", "\n", "\r\n").

It also provides a robust solution for line endings split across chunks (the issue from the todo comment that points to https://bitbucket.org/dmitry_cherkas/intellij-serial-monitor/issues/1), replacing the previous temporary fix. Since the bitbucket repo is offline I had to use ribasco/intellij-serial-monitor@1414af0 to find the linked issue.
@Crementif
Copy link
Author

Crementif commented Oct 30, 2023

Would it help to have a bug tracker entry about the bug that this PR fixed? Would be nice to have this fix implemented for me and some other folks that have to use additional programs currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant