Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cucumber] Fix StringIndexOutOfBoundsException on CucumberJavaParamet… #763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Cucumber] Fix StringIndexOutOfBoundsException on CucumberJavaParamet… #763

wants to merge 1 commit into from

Conversation

sshuvalov
Copy link
Contributor

…erTypeReference.getParameterTypeName()

Added additional annotation type check.

@sshuvalov
[Cucumber] Fix StringIndexOutOfBoundsException on CucumberJavaParamet…
c8dee0b 
…erTypeReference.getParameterTypeName()

Added additional annotation type check.
@sshuvalov
Copy link
Contributor Author

@avokin review this?

@avokin2 avokin2 requested review from avokin2 and removed request for avokin February 11, 2021 15:16
@avokin2 avokin2 assigned avokin2 and unassigned avokin Feb 11, 2021
@avokin2
Copy link

avokin2 commented Nov 14, 2021

Could you provide the exception's stacktrace?

This check should be done in CucumberJavaUtil#isCucumberStepAnnotation. Also I suggest not to use class names from CucumberJavaExtension#CUCUMBER_JAVA_STEP_DEFINITION_ANNOTATION_CLASSES. It's classmarkers to detect cucumber-java library version (no guarantee that this list contains step definition annotations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avokin2 avokin2 Awaiting requested review from avokin2

Assignees

@avokin2 avokin2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshuvalov @avokin2 @avokin