Support multiplatform BackHandler/PredictiveBackHandler.
#1771
+1,049
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jan 10, 2025
...ial3/material3/src/uikitMain/kotlin/androidx/compose/material3/internal/BackHandler.uikit.kt
Outdated
Show resolved
Hide resolved
compose/mpp/demo/src/uikitMain/kotlin/androidx/compose/mpp/demo/UIKitPredictiveBackExample.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitBackEvent.kt
Outdated
Show resolved
Hide resolved
...ose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitPredictiveBackHandler.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.kt
Outdated
Show resolved
Hide resolved
...topMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.desktop.kt
Outdated
Show resolved
Hide resolved
...macosMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.macos.kt
Outdated
Show resolved
Hide resolved
...uikitMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.uikit.kt
Outdated
Show resolved
Hide resolved
...src/webMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.web.kt
Outdated
Show resolved
Hide resolved
terrakok
force-pushed
the
k.tskh/ios-back-gesture
branch
from
e36fb22 to
8ad3ee6
Compare
MatkovIvan
requested changes
Jan 13, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/backhandler/BackEventCompat.kt
Outdated
Show resolved
Hide resolved
terrakok
force-pushed
the
k.tskh/ios-back-gesture
branch
from
54d51a3 to
99c6ebc
Compare
terrakok
changed the title
BackHandler/PredictiveBackHandler.
terrakok
changed the title
BackHandler/PredictiveBackHandler.BackHandler/PredictiveBackHandler.
MatkovIvan
requested changes
Jan 17, 2025
...ose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
Outdated
Show resolved
Hide resolved
...ose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
Outdated
Show resolved
Hide resolved
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Outdated
Show resolved
Hide resolved
...material3/material3/src/commonMain/kotlin/androidx/compose/material3/internal/BackHandler.kt
Outdated
Show resolved
Hide resolved
...ui-backhandler/src/androidMain/kotlin/androidx/compose/ui/backhandler/BackHandler.android.kt
Show resolved
Hide resolved
...e/ui/ui-backhandler/src/commonMain/kotlin/androidx/compose/ui/backhandler/BackEventCompat.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-backhandler/src/jbMain/kotlin/androidx/compose/ui/backhandler/BackHandler.jb.kt
Outdated
Show resolved
Hide resolved
ASalavei
reviewed
Jan 17, 2025
| } | ||
|
|
||
| fun setView(rootView: UIView) { | ||
| rootView.addGestureRecognizer(leftEdgePanGestureRecognizer) |
There was a problem hiding this comment.
Gesture recognizers must be removed from view when they not needed. Currently, I can see 2 events:
ComposeHostingViewController.dispose()- when window is null in
onDidMoveToWindow(window: UIWindow?)
There was a problem hiding this comment.
We discussed it with @elijah-semyonov and decided it is not needed here.
There was a problem hiding this comment.
As far as I can see, it creates 2 gesture recognisers per each ComposeHostingViewController and add them to some external view - these recognisers will stay there forever. So I think we need to delete them anyway.
There was a problem hiding this comment.
will stay there forever
no. when ComposeHostingViewController is gone, it will be destroyed because a system view keeps a weak reference
| velX < -10 -> listener.onCancelled() | ||
| //if there is no movement, or the movement is slow, | ||
| //but the touch is already more than BACK_GESTURE_SCREEN_SIZE | ||
| abs(x) >= size.width * BACK_GESTURE_SCREEN_SIZE -> listener.onCompleted() |
There was a problem hiding this comment.
On iOS it's a bit more complicated. It looks more like: min(200.dp, bounds.width / 2), or similar..
I think we need to play (in another MR) here a bit to make behavior close to what we have in UINavigationController
...ose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitBackGestureDispatcher.kt
Outdated
Show resolved
Hide resolved
terrakok
force-pushed
the
k.tskh/ios-back-gesture
branch
2 times, most recently
from
5653ec4 to
1cd1470
Compare
terrakok
force-pushed
the
k.tskh/ios-back-gesture
branch
from
1cd1470 to
bcdb1ba
Compare
… them via a compose static local.
…led. It is not possible to run a suspend function when the progress flow is canceled because the onBack suspend lambda is canceled as well. See: androidx.activity.compose.OnBackInstance.cancel
terrakok
force-pushed
the
k.tskh/ios-back-gesture
branch
from
bcdb1ba to
15aa84a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
BackHandler/PredictiveBackHandler.Fixes https://youtrack.jetbrains.com/issue/CMP-4419
Screen.Recording.2025-01-10.at.21.19.40.mov
Testing
Release Notes
Highlights - Multiple Platforms
BackHandlerandPredictiveBackHandler. And use them in material3 widgets and androidx-navigation library.