Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling/userview #44

Merged
merged 22 commits into from
Jan 7, 2024
Merged

Styling/userview #44

merged 22 commits into from
Jan 7, 2024

Conversation

Jesuitman
Copy link
Owner

@Jesuitman Jesuitman commented Jan 7, 2024

What I did:
added in styling for userview in the profile, also added in proptypes, thank you joshi. Cypress testing is present on main now, but should be ignored for the sake of testing on our testing specific branch.

Did this break anything?

  • No
  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)
  • Styling
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain the fix.

Checklist:

  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing

What's next?
this is a finished product

@Jesuitman Jesuitman added the extension optional label Jan 7, 2024
@Jesuitman Jesuitman self-assigned this Jan 7, 2024
Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
m3-h8r-aid ✅ Ready (Inspect) Visit Preview Jan 7, 2024 11:37pm

This was linked to issues Jan 7, 2024
Copy link
Collaborator

@tenthwalker tenthwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping me get this wrapped up Lex, you're the best!

@tenthwalker tenthwalker added enhancement New feature or request dev task dev story + workflow labels Jan 7, 2024
@MaryBruff
Copy link
Collaborator

Beauty! Great work!

</div>
)}
</div>
</ErrorBoundary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

}

.filter-buttons, .profile {
display: flex;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

She cute

@tenthwalker tenthwalker merged commit 3109640 into main Jan 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment