Feat/styling #28
Merged
Feat/styling #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthwalker
added
enhancement
Jesuitman
reviewed
Jan 2, 2024
| @@ -10,34 +10,11 @@ | |||
| content="Web site created using create-react-app" | |||
| /> | |||
| <link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" /> | |||
| <!-- | |||
There was a problem hiding this comment.
good job cleaning this up! i didnt even thin kto check that out
Jesuitman
reviewed
Jan 2, 2024
| } | ||
|
|
||
| .header-text { | ||
| color: blue; | ||
| background-color: #FDFFFC; | ||
| border-bottom: .5rem solid #235789; |
Jesuitman
reviewed
Jan 2, 2024
| .card p { | ||
| font-size: 14px; | ||
| flex-grow: 1; | ||
| overflow: hidden; |
Jesuitman
reviewed
Jan 2, 2024
| @@ -16,11 +16,11 @@ const Card = ({ snippet }) => { | |||
|
|
|||
| return ( | |||
| <div className="card"> | |||
| <div className="card-content" onClick={handleTitleClick}> | |||
| <article className="card-content" onClick={handleTitleClick}> | |||
Jesuitman
reviewed
Jan 2, 2024
| border-bottom: 0.5rem solid #C1292E; | ||
| border-right: 0.5rem solid #C1292E; | ||
| width: fit-content; | ||
| } |
JoeyStewart
approved these changes
Jan 2, 2024
|
Incredible work! |
Jesuitman
reviewed
Jan 2, 2024
| .then((data) => { | ||
| await fetch(url + new URLSearchParams(params).toString()) | ||
| .then((response) => { | ||
| if (!response.ok) { |
There was a problem hiding this comment.
that spacing looks incredible, i love that you cleaned so much up
MaryBruff
reviewed
Jan 2, 2024
| #resultName { | ||
| align-self: center; | ||
| color: #161925; | ||
| background-color: #FDFFFC; |
There was a problem hiding this comment.
Yeah the primary colors turned out really well! I love how it looks!
Jesuitman
reviewed
Jan 2, 2024
| transition: background-color 0.3s ease; | ||
| } | ||
| .saveButton, .favoriteButton { | ||
| background-color: #161925; |
There was a problem hiding this comment.
the use of primary colors makes it really pop off, well done
Jesuitman
approved these changes
Jan 2, 2024
nicktu12
reviewed
Jan 3, 2024
| } | ||
| } | ||
|
|
||
| @media screen and (max-width: 500px) { |
nicktu12
reviewed
Jan 3, 2024
| console.error('There was a problem with the fetch operation:', error); | ||
| }); | ||
| } | ||
| setInitialResults(data.query.search[0]); |
There was a problem hiding this comment.
data.query.search[0] is quite a handful - could you store this in a variable with an appropriate variable name to improve readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
This pull request adds styling to bring the project in line with the wireframe and style inspiration. It updates colors, borders, layouts, class/id naming where necessary, responsive design flexibility, and removes placeholder/boilerplate code.
Did this break anything?
Type of change
Checklist:
What's next?
Incorporation of Auth0 to nail down how that will impact any further styling.