Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features and Bug Fixes #68

Closed
wants to merge 3 commits into from
Closed

Features and Bug Fixes #68

wants to merge 3 commits into from

Conversation

ProIcons
Copy link

@ProIcons ProIcons commented Feb 1, 2021

Fixed #76, #73, #70
Implemented #75, #74, #72, #71, #69

@ProIcons ProIcons changed the title Remove unnecessary obsolete destructors. Features and Bug Fixes Feb 2, 2021
@ProIcons
Copy link
Author

ProIcons commented Feb 2, 2021

At this point i want to note that storing these access tokens unencrypted is not a good idea. There needs to be some kind of data protection which i'm working on it.

@ProIcons
Copy link
Author

ProIcons commented Feb 2, 2021

I implemented security on 301cabc

@srth21
Copy link
Contributor

srth21 commented Feb 4, 2021

At this point i want to note that storing these access tokens unencrypted is not a good idea. There needs to be some kind of data protection which i'm working on it.

How about some form of a local cache?

@ProIcons
Copy link
Author

ProIcons commented Feb 4, 2021

Since the project isn't using appsettings.json for actuall app settings, i stored it inside there , encrypted. refer to the last commit.

@ProIcons ProIcons closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store market to appsettings.config to be configurable.
2 participants