PHP7 Fatal Errors fixed #33 #34

amenk · 2016-02-08T17:23:38Z

Use Contracts in Parameters
added the "use" statement to a closure

* Use Contracts in Parameters * added the "use" statement to a closure

Nitpick-CI · 2016-02-08T17:23:53Z

src/Adapters/Eloquent/EloquentAlbumAdapter.php

@@ -42,7 +43,7 @@ public function findHidden($id)
    public function findByAttribute(array $attribute)
    {
        $collection = [];
-        $all = Album::where(function($query) {
+        $all = Album::where(function($query) use ($attribute) {


Expected 1 space after FUNCTION keyword; 0 found

I think we should refer directly in the module, not using a global facade (which is actually not defined)

Nitpick-CI · 2016-02-08T17:56:56Z

src/Controllers/GalleryController.php

@@ -11,7 +13,7 @@ class GalleryController extends Controller
     */
 	public function index()
 	{
-		$allAlbums = \Gallery::album()->all();
+		$allAlbums = Gallery::album()->all();


Spaces must be used to indent lines; tabs are not allowed

I think we should refer directly in the module, not using a global facade (which is actually not defined)

Nitpick-CI · 2016-02-08T18:00:38Z

src/Controllers/PhotosController.php

@@ -14,7 +15,7 @@ class PhotosController extends Controller
 	 */
 	public function create()
 	{
-		$albumArray = \Gallery::album()->all()->toArray();
+		$albumArray = Gallery::album()->all()->toArray();


Spaces must be used to indent lines; tabs are not allowed

amenk · 2016-02-08T18:01:22Z

@Nitpick-CI you are very annoying :-)

I think we should refer directly in the module, not using a global facade (which is actually not defined)

Nitpick-CI · 2016-02-08T18:09:50Z

src/Controllers/AlbumsController.php

@@ -38,7 +39,7 @@ public function store(Request $request)
 			'order' => 0,
 		]);

-		\Gallery::album()->add($album);
+		Gallery::album()->add($album);


Spaces must be used to indent lines; tabs are not allowed

Fixes ...

Nitpick-CI · 2016-02-08T18:24:04Z

src/Controllers/PhotosController.php

@@ -65,7 +66,7 @@ public function store(Request $request)
 	 */
 	public function show($albumId, $photoId)
 	{
-		$photo = \Gallery::photo()->find($photoId);
+		$photo = Gallery::photo()->find($photoId);


Spaces must be used to indent lines; tabs are not allowed

PHP7 Fatal Errors fixed

13298e3

* Use Contracts in Parameters * added the "use" statement to a closure