Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Tagger Energy Correction Function #85

Merged
merged 23 commits into from
May 22, 2024

Conversation

asligonulacar
Copy link
Contributor

Implemented the Forward Tagger energy correction function as an IGUANA algorithm. Please let me know if I have made any errors. This is mainly a placeholder until a more complicated algorithm can be implemented. This function is currently only validated for Fall 2018 outbending data.

@c-dilks
Copy link
Member

c-dilks commented Feb 9, 2024

Do you need ROOT dependence for this algorithm? I plan to add it soon...

@c-dilks
Copy link
Member

c-dilks commented Feb 22, 2024

Do you need ROOT dependence for this algorithm? I plan to add it soon...

We now allow algorithms to depend on ROOT; however, try to use the new ROOT::Math vectors rather than TLorentzVector. The updated LorentzTransformer algorithm demonstrates a boost with ROOT::Math::Boost.

@c-dilks
Copy link
Member

c-dilks commented Feb 22, 2024

Some other things of note:

  • add your algorithm to src/iguana/algorithms/meson.build so that it's included in the build; if it depends on ROOT, set needs_ROOT to true
  • add your name to the CODEOWNERS file and attach it to your algorithm's files

@dglazier
Copy link
Contributor

dglazier commented May 9, 2024

Hi folks,
What is the status of the iguana FT correction ? It looks like this has not been merged yet, and there is a test fail. Does this need some work ? I would like to try out this algorithm.
Cheers
Derek

@c-dilks
Copy link
Member

c-dilks commented May 9, 2024

@dglazier it needed some work to catch up with the main branch. I updated this algorithm and spot checked the output, but it needs validation, in particular a "Validator" type algorithm (see, e.g., MomentumCorrectionValidator which makes plots of the corrections from the MomentumCorrection algorithm).

@asligonulacar can you check the new version of your algorithm, and would you be willing to write such a validator?

@c-dilks c-dilks marked this pull request as ready for review May 9, 2024 22:26
@c-dilks c-dilks self-requested a review as a code owner May 9, 2024 22:26
@c-dilks c-dilks merged commit 49f4093 into JeffersonLab:main May 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants