Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build shared fmt libraries #76

Closed
wants to merge 4 commits into from
Closed

fix: build shared fmt libraries #76

wants to merge 4 commits into from

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Jan 12, 2024

See fmt build option documentation:
https://github.com/fmtlib/fmt/blob/bf98e3e4c61a7f5c36633278da6567f7bcedd4d5/doc/usage.rst?plain=1#L48-L60

Resolves #75 no, this should be a fallback if static libfmt doesn't exist

cppyy on macOS seems to rely on the shared (dynamic) fmt library, which wasn't being built on the CI or recommended in the documentation. In fact, the Homebrew fmt formula builds both the static and dynamic libraries (whereas, e.g., Arch Linux only builds the shared library.

@c-dilks c-dilks linked an issue Jan 12, 2024 that may be closed by this pull request
3 tasks
@c-dilks c-dilks changed the title fix: build shared fmt libraries, not static fix: build shared fmt libraries Jan 12, 2024
@c-dilks c-dilks removed a link to an issue Jan 13, 2024
3 tasks
@c-dilks
Copy link
Member Author

c-dilks commented Jan 13, 2024

Perhaps we close this PR, since:

  • systems which only have shared fmt libs should work fine, since they will be found in the default locations (no rpath additions needed)
  • users who build fmt themselves should build the static library, not the shared library
  • macOS users who want to use the Python bindings will have to build both, since for some reason cppyy on macOS requires the shared libraries; this is what its Homebrew formula does

@c-dilks c-dilks closed this Jan 13, 2024
@c-dilks c-dilks deleted the fmt-shared branch January 13, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant