Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new detector with v4.4b alignment #1042

Merged
merged 2 commits into from
Jun 21, 2024
Merged

new detector with v4.4b alignment #1042

merged 2 commits into from
Jun 21, 2024

Conversation

bloodyyugo
Copy link
Contributor

@bloodyyugo bloodyyugo commented Jun 12, 2024 •
edited
Loading

cbravo135
cbravo135 reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually have the directory name, the name in the compact.xml and the name in detector.properties all match.

@bloodyyugo bloodyyugo requested review from sarahgaiser and pbutti June 20, 2024 13:15
@sarahgaiser sarahgaiser merged commit 1711eb9 into master Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahgaiser sarahgaiser sarahgaiser approved these changes

@cbravo135 cbravo135 cbravo135 approved these changes

@pbutti pbutti Awaiting requested review from pbutti

Assignees

@cbravo135 cbravo135

@pbutti pbutti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bloodyyugo @cbravo135 @sarahgaiser @pbutti