Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding overlay for 2016 #1039

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sarahgaiser
Copy link
Collaborator

No description provided.

@tongtongcao
Copy link
Contributor

Thanks for the nice work.

Here are my comments for coding:
Basically, the updates are for application of 2016 DAQ configuration in the new digitization system.
So Similar updates can be taken as PR#1019 for the updates for application of 2016 DAQ configuration.

  1. For EcalDigitizationWithPulserDataMergingReadout2016Driver.java, do not need to add this new driver. Instead, you can update EcalDigitizationWithPulserDataMergingReadoutDriver.java. Refer to driver for how to do updates.

  2. For the new steering file, since DAQ configuration is applied, parameters for digitization and trigger system are loaded from the DAQ configuration and they are run dependent, so do not set them in the steering file. Refer to steering file

@tongtongcao
Copy link
Contributor

tongtongcao commented May 29, 2024

Looks fine for me. But validation is needed before approval.
Keep one thing in mind:
According to experience of 2019&2021, peak for delta_time between track and cluster might change due to the new readout system. So <trackClusterTimeOffset>36.8</trackClusterTimeOffset> in reconstruction steering files might need to be updated.

@bloodyyugo
Copy link
Contributor

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants