Fix the cast to String #1013
Merged
Fix the cast to String #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-celentano
requested review from
cbravo135,
JeremyMcCormick,
omar-moreno,
baltzell and
normangraf
normangraf
approved these changes
Sep 23, 2023
cbravo135
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Looks reasonable and is isolated to a cli tool provided in the package for reading the db. Just want to point out that one can retrieve the same information by logging into the db server and using mysql commands to get it to dump the data loaded in the tables.
andrea-celentano
deleted the
1012-fix-the-conditions-option-command-line-tool-print-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.