Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hall B pressure timeline #132

Merged
merged 14 commits into from
Nov 13, 2023
Merged

feat: add Hall B pressure timeline #132

merged 14 commits into from
Nov 13, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Oct 27, 2023

Requested by @hauenst

  • Adds Hall B pressure, temperature, and humidity
  • Fixes EPICS BPM timeline for RG-D, which requires ops MYA deployment instead of history; this is done by first querying ops, and if that fails, it queries history (and if that fails, an exception is thrown)

@c-dilks
Copy link
Member Author

c-dilks commented Oct 28, 2023

Currently blocked by JeffersonLab/rcdb#101, if we indeed need the run start and stop time to correctly query MYA.

@c-dilks
Copy link
Member Author

c-dilks commented Nov 3, 2023

myquery will work, following the example of epics_xy.groovy; CI tests will not, so --skip-mya will be used after #140.

We'll need to do something about the ops vs. history decision though...

@c-dilks
Copy link
Member Author

c-dilks commented Nov 7, 2023

Refactored, centralized myquery usage appears to finally be working. Current online EPICS timelines for RG-D are broken, since the main version of the code uses the history deployment of MYA, rather than ops, so I'm cross checking this PR with #143.

For a few sample runs, the 2H01 y position is not a single Gaussian, and the fits are bad, e.g.,
image

This is a new, RG-D specific issue, and out of scope of this PR.

The good news is that obtaining the Hall pressure for @hauenst should be relatively straightforward now.

@c-dilks c-dilks marked this pull request as ready for review November 13, 2023 15:10
@c-dilks c-dilks merged commit f93bd4f into main Nov 13, 2023
10 checks passed
@c-dilks c-dilks deleted the weather-pressure branch November 13, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant