Adding Tests #9
Merged
Adding Tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travipross
commented
Apr 7, 2022
travipross
commented
Apr 7, 2022
Closed
travipross
commented
Apr 7, 2022
|
@JeffResc looks good to me but since you had been working more closely with the tests could you take a look as well? |
|
Hi @travipross - Thanks for the PR, I really appreciate it! I don't have time to review this right this second, but I just wanted to reach out and say thank you. I should have time later this week and definitely by the end of this weekend to give this a look. |
|
No rush on my end! I'll probably keep tinkering away until then |
|
We're a little lacking on coverage, but it's definitely a start! Thanks @travipross 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
This introduces a
pytestsuite of tests along with some configuration. So far, a number of unit tests have been written to cover all of the AylaApi methods that do not make any external web request. More tests can be added to this PR, or a new one could be created in the future to extend this baseline.I'd also be happy to integrate the tests into a new github actions workflow to run on pull requests, however, I lack the permissions. Proper authentication/integration tests would also likely require a valid Shark login to be stored as a repository secret.