This repository has been archived by the owner on May 11, 2021. It is now read-only.
Add feature #91(Enabling selective import of states) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sudo-panda , i tried to import the following behavior of prius_in_city to use the overtake behavior. But the results are not as desired.
|
|
On it. |
|
Done |
|
The transition is still remaining while importing. We just need the state. |
|
That's the issue #109. Going to work on it today. |
|
Oh cool. Let's solve that issue first then proceed with this PR. |
|
Ok |
sudo-panda
changed the title
|
Hi @sudo-panda . What is the status of this PR? |
|
It's waiting for review. |
|
The PR looks good to me. We are planning a release for VisualStates, meanwhile, we'll keep this PR on this branch and add it for next release. Thanks, @sudo-panda for the PR. |
|
As the feature is being developed on the GSoC development repository, closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dialog in import process to enable selective import of states