[MIG] [18.0] hr_grade_rank: migrated module #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing is assigned to Pooja |
Trivedi-Vacha-SerpentCS
requested changes
Oct 23, 2024
| </sheet> | ||
| </form> | ||
| </field> | ||
| </record> | ||
|
|
||
| <!-- GRADE TREE VIEW --> | ||
| <record id="view_employee_grade_tree" model="ir.ui.view"> | ||
| <field name="name">grade.grade.tree</field> | ||
| <record id="view_employee_grade_list" model="ir.ui.view"> |
There was a problem hiding this comment.
No need to replace tree with list in the ID of any view. as it may cause issues if define reference of the view based on ID.
| </sheet> | ||
| </form> | ||
| </field> | ||
| </record> | ||
|
|
||
| <!-- RANK TREE VIEW --> | ||
| <record id="view_employee_rank_tree" model="ir.ui.view"> | ||
| <field name="name">rank.rank.tree</field> | ||
| <record id="view_employee_rank_list" model="ir.ui.view"> |
There was a problem hiding this comment.
same as above, do not change the view ID
| </field> | ||
| </field> | ||
| </record> | ||
|
|
||
| <!-- EMPLOYEES INHERITED TREE VIEW --> | ||
| <record id="view_employee_tree_grade_rank" model="ir.ui.view"> | ||
| <field name="name">hr.employee.tree.grade.rank</field> | ||
| <record id="view_employee_list_grade_rank" model="ir.ui.view"> |
There was a problem hiding this comment.
same as above
Trivedi-Vacha-SerpentCS
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsible : Jayram