-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] [17.0] label: migrated module. #648
Open
ShwetaSerpentCS
wants to merge
53
commits into
JayVora-SerpentCS:17.0
Choose a base branch
from
ShwetaSerpentCS:MIG_label_17
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[MIG] [17.0] label: migrated module. #648
ShwetaSerpentCS
wants to merge
53
commits into
JayVora-SerpentCS:17.0
from
ShwetaSerpentCS:MIG_label_17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP]Improved code in js. [IMP]Js Travis Fix. [IMP]Js Travis Fix. [IMP]Js Travis Fix.
Testing is assigned to Pooja |
Trivedi-Vacha-SerpentCS
requested changes
Sep 13, 2024
@Trivedi-Vacha-SerpentCS Please review updated code. |
23 tasks
ShwetaSerpentCS
force-pushed
the
MIG_label_17
branch
from
November 27, 2024 09:17
c55b0fb
to
7cf5ed4
Compare
QA done with index by Pooja |
Trivedi-Vacha-SerpentCS
added
QA Pass
and removed
In QA
Under testing by QA team
labels
Nov 27, 2024
@Trivedi-Vacha-SerpentCS @Murtaza-SerpentCS pls review |
Trivedi-Vacha-SerpentCS
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing docstring in methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsible : Deepak