Formatted with cargo clippy
and removed redundant code
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[doc(hidden)]
is redundant on private items unless you compile docs with--document-private-items
Hotp
andTotp
methods.todo!()
ingenerate_otpauth_url
x / 1
orx & 0xFF
removed in favor of*x
.assert_eq!(x, true)
replaced withassert!(x)
, same withfalse
.There are still things that I haven't done that could be done:
2021
, it should be compatibledebug_assert
to optimize for release buildsassert!(cond, "cond was false, that shouldn't happen")
)otpauth
URL generation (I could make a PR if you wanted)generate_otpauth_url
behind a feature in theCargo.toml
fileNote:
otpauth
URLsCargo.toml