Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shimmer transmutations to the recipe browser #142

Open
wants to merge 4 commits into
base: 1.4
Choose a base branch
from

Conversation

Kyryh
Copy link

@Kyryh Kyryh commented Apr 14, 2024

And other minor things about recipe info displaying, like:

  • Removing the "None" from the "Required objects" section when there's at least one condition
  • Removing the "Recipe added by " tooltip line for recipes added by Recipe Browser (only the shimmer ones in this case)

There were multiple approaches that could've be done, so I went with the easiest one (I hope that's ok): simply adding the shimmer transmutations as fake recipes with a condition that can never be fulfilled, that way the recipe browser is able to seamlessly detect it and add it, and it shouldn't change anything gameplay-wise since you can never actually craft the items because of the condition

Kyryh added 4 commits April 14, 2024 21:08
It registers fake recipes with a condition that you can never actually fulfill, that way it doesn't change the gameplay in any way
Now it doesn't add the "Recipe added by mod" tooltip if the mod in question is Recipe Browser
Useful only now with fake shimmer recipes
Now it adds "None" to the required objects only if the recipe has no required tiles and no conditions
@JavidPack
Copy link
Owner

Thanks, I'll try to take a look soon when I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants