Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new hotkey to close the interface #126

Open
wants to merge 1 commit into
base: 1.4
Choose a base branch
from

Conversation

Nyxeka
Copy link

@Nyxeka Nyxeka commented Jan 7, 2024

occasionally, if the UI toggle hotkey is more accessible, it can be accidentally pressed. This adds the option to set a close hotkey for if you happen to open the recipe browser during a boss fight or something

occasionally, if the UI toggle hotkey is more accessable, it can be
accidentally pressed. This adds the option to set a close hotkey
for if you happen to open the recipe browser during a boss fight
or something
@Nyxeka
Copy link
Author

Nyxeka commented Jan 7, 2024

Using this locally, figured I'd put it up in case you'd like to add.

I personally use escape key because it's just muscle memory to try to close it by spamming escape key, even if it toggles inventory.

should be noted that toggling still works the same, this just adds the ability to quickly get out of the interface in panic-moments and such.

tested:

  • opening with toggle hotkey, closing with close hotkey
  • opening and closing with toggle hotkey

@JavidPack
Copy link
Owner

I can see this potentially being useful, but why wouldn't you just press the toggle recipe browser hotkey again instead of needing a new hotkey? Opening the inventory as a side result of trying to close the window seems wonky.

@Nyxeka
Copy link
Author

Nyxeka commented Jan 9, 2024

Most of the time I have the hotkey sey to something like 'n' key, I don't use it enough for muscle memory and go into blind panic and try to close it with the escape key when it accidentally opens while trying to fight some harder bosses. usually it's not an issue but I figured it was easy enough to add and it's already come in use for me.

I also find myself using it just in general. the muscle memory may be linked to closing the chest/crafting interface?

This may very well be too niche for the general populous, I won't be offended if it's closed heh.

@Nyxeka
Copy link
Author

Nyxeka commented Jan 9, 2024

also brings up the question if instead there could be a setting toggle that links the recipe browser to opening the inventory; or at least open the inventory like a chest, where hitting escape would close out everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants