Merge pull request warewulf#1451 from JasonYangShadow/issue/964

fix issue that pattern matching broken on node set
JasonYangShadow · Oct 11, 2024 · f0e4dcc · f0e4dcc
2 parents f102bb9 + f51808b
commit f0e4dcc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -52,6 +52,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Return non-zero exit code on node sub-commands #1421
 - Fix panic when getting a long container list before building the container. #1391
 - Return non-zero exit code on power sub-commands #1439
+- Fix issue that pattern matching broken on `node set` #964
 
 ## v4.5.8, 2024-10-01
 

diff --git a/internal/pkg/api/node/node.go b/internal/pkg/api/node/node.go
@@ -234,7 +234,8 @@ func NodeSetParameterCheck(set *wwapiv1.NodeSetParameter, console bool) (nodeDB
 			fmt.Printf("\n*** WARNING: This command will modify all nodes! ***\n\n")
 		}
 	} else {
-		nodes = node.FilterByName(nodes, set.NodeNames)
+		expandNodes := hostlist.Expand(set.NodeNames)
+		nodes = node.FilterByName(nodes, expandNodes)
 	}
 
 	if len(nodes) == 0 {