Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tablestore from Alicloud as the new storage backend #4721

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

opan
Copy link

@opan opan commented Nov 6, 2024


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Copy link

CLA Not Signed

@porunov
Copy link
Member

porunov commented Nov 6, 2024

Thank you @opan for the contribution!

It's always great to see new storage implementations. However, usually adding storage implementation directly into JanusGraph adds some burden if there are no active contributors for such storage implementations.
Thus, JanusGraph supports storage adapters which can be developed outside on the main JanusGraph code base and they work as plug-in systems.
For example, we have FoundationDB storage adapter located here: https://github.com/JanusGraph/janusgraph-foundationdb
There are also other storage adapter like:
Aerospike: https://github.com/PlaytikaOSS/aerospike-janusgraph-storage-backend
DynamoDB: https://github.com/amazon-archives/dynamodb-janusgraph-storage-backend

Would you consider converting your storage implementation into a storage adapter? If community wants and there are people willing to maintain it then we can also onboard this storage adapter under a separate repository hosted inside JanusGraph organization for wider adoption.

Btw. we have janusgraph-dev mailing list where we usually discuss such contributions.

Let me know what you think about it.

@opan
Copy link
Author

opan commented Nov 6, 2024

Hi @porunov , thank you for the response! I think I'll have to discuss this with my team first and after that will get back here with some updates whether we are going to pursue merging this with janusgraph code base or follows the plug-in systems like those samples you have shared.

@opan
Copy link
Author

opan commented Nov 6, 2024

btw, forgot to ask, is there any docs or guides on how to create plug-in for a new storage backend in janusgraph?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants