-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Tablestore from Alicloud as the new storage backend #4721
base: master
Are you sure you want to change the base?
Conversation
upgrade tablestore as a new backend
|
Thank you @opan for the contribution! It's always great to see new storage implementations. However, usually adding storage implementation directly into JanusGraph adds some burden if there are no active contributors for such storage implementations. Would you consider converting your storage implementation into a storage adapter? If community wants and there are people willing to maintain it then we can also onboard this storage adapter under a separate repository hosted inside JanusGraph organization for wider adoption. Btw. we have janusgraph-dev mailing list where we usually discuss such contributions. Let me know what you think about it. |
Hi @porunov , thank you for the response! I think I'll have to discuss this with my team first and after that will get back here with some updates whether we are going to pursue merging this with janusgraph code base or follows the plug-in systems like those samples you have shared. |
btw, forgot to ask, is there any docs or guides on how to create plug-in for a new storage backend in janusgraph? |
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: