Skip to content

Commit

Permalink
Making lazy-load relations TRUE by default
Browse files Browse the repository at this point in the history
Signed-off-by: ntisseyre <[email protected]>
[cql-tests][tp-tests]
  • Loading branch information
ntisseyre committed Apr 12, 2024
1 parent 9709a6f commit cd8477c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@
import org.janusgraph.testutil.TestGraphConfigs;
import org.janusgraph.util.IDUtils;
import org.janusgraph.util.stats.MetricManager;
import org.junit.Assert;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -2644,7 +2645,8 @@ public void testPropertyIdAccessInDifferentTransaction() {

// access property id in new transaction
graph.tx().commit();
assertEquals(expectedId, p.id());
Exception exception = Assert.assertThrows(IllegalStateException.class, p::id);
assertEquals(exception.getMessage(), "Any lazy load operation is not supported when transaction is already closed.");
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public class StandardTransactionBuilder implements TransactionConfiguration, Tra

private boolean skipDBCacheRead;

private boolean isLazyLoadRelations;
private boolean isLazyLoadRelations = true;

private MultiQueryHasStepStrategyMode hasStepStrategyMode;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,9 @@

package org.janusgraph.graphdb.inmemory;

import org.apache.tinkerpop.gremlin.structure.VertexProperty;
import org.janusgraph.core.JanusGraphVertex;
import org.janusgraph.diskstorage.configuration.WriteConfiguration;
import org.janusgraph.graphdb.configuration.builder.GraphDatabaseConfigurationBuilder;
import org.janusgraph.graphdb.database.LazyLoadGraphTest;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertThrows;
import static org.junit.jupiter.api.Assertions.assertEquals;

/**
* @author Matthias Broecheler ([email protected])
Expand All @@ -36,18 +30,4 @@ public void open(WriteConfiguration config) {
tx = graph.buildTransaction().start();
mgmt = graph.openManagement();
}

@Override @Test
public void testPropertyIdAccessInDifferentTransaction() {
JanusGraphVertex v1 = graph.addVertex();
Object expectedId = v1.property("name", "foo").id();
graph.tx().commit();

VertexProperty p = getOnlyElement(v1.properties("name"));

// access property id in new transaction
graph.tx().commit();
Exception exception = assertThrows(IllegalStateException.class, p::id);
assertEquals(exception.getMessage(), "Any lazy load operation is not supported when transaction is already closed.");
}
}

0 comments on commit cd8477c

Please sign in to comment.