Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump com.github.spotbugs:spotbugs-maven-plugin from 4.7.3.4 to 4.8.6.5 in /jans-core #9880

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2024

Bumps com.github.spotbugs:spotbugs-maven-plugin from 4.7.3.4 to 4.8.6.5.

Release notes

Sourced from com.github.spotbugs:spotbugs-maven-plugin's releases.

Spotbugs Maven Plugin 4.8.6.5

  • Moved most 'read' only maven injections to read data from maven session instead to overcome many deprecated usage. This puts it on their api and thus if things are internally deprecated, its then maven's issue rather than this plugin to figure out.
  • remove obsolete script source roots as no longer support in maven 4 and technically I've never seen them used. Please let me know if this negatively affects you as there are other manually coded items like kotlin / groovy that are in the code there so scripts could be manually added back.
  • Remove some of the read only attributes for maven injection that were not actually used.
  • More def to object type
  • Various lib / plugin updates
  • Enable partial formatting (mostly removing trailing whitespace)

Compatibility remains with 4.8.6 of spotbugs

Spotbugs Maven Plugin 4.8.6.4

  • Groovy set to 4.0.23
  • Drop maven site plugin 3.6 and before support.

Spotbugs Maven Plugin 4.8.6.3

  • Ability to disable logs in quite mode (spotbugs.quiet) #842
  • Fix output directory per #807
  • Update plugins / dependencies
  • Fix tag used to build spotbugs during GHA
  • Use inject annotation from jsr330 instead of deprecated component annotation

Build

  • Remove old overrides from pom as addressed
  • Cleanup javadocs
  • Remove snapshot from javadocs at 2.1 as non existent
  • Order attribute order of annotations
  • Use log commonly throughout (newer coded used getLog in one place)
  • Sort imports
  • Add opens for java.lang and java.util for site build as needed on newer jdks
  • Correct GHA for site distribution
  • Delete duplicate codeql github action
  • Speed up github actions

Spotbugs Maven Plugin 4.8.6.2

  • Supports spotbugs 4.8.6
  • Uses groovy 4.0.22

Spotbugs Maven Plugin 4.8.6.1

  • Supports spotbugs 4.8.6
  • Restore java 8 support

Spotbugs Maven Plugin 4.8.6.0

Support spotbugs 4.8.6

WARNING: This version accidentally required java 11. A patch is incoming that will move back to java 8. Do note though spotbugs will be moving up in near future.

Spotbugs Maven Plugin 4.8.5.0

  • Support spotbugs 4.8.5.0
  • Dependency and plugin general updates
  • Maven wrapper update to 3.3.1

... (truncated)

Commits
  • 105a31a [maven-release-plugin] prepare release spotbugs-maven-plugin-4.8.6.5
  • 39c76bc [pom] Bump junit to 5.11.3
  • cb3c776 Merge pull request #910 from hazendaz/formatting
  • 800b0b4 [maven] Use source/test roots from session
  • b7cbbde Merge pull request #909 from hazendaz/formatting
  • b1bd51b [cleanup] Remove injected resource bundle as not used that way
  • 363efbd Merge pull request #908 from hazendaz/formatting
  • dca7267 [fix] Correct tag back to HEAD and fix licensing
  • ba920cc Merge pull request #907 from hazendaz/thorough-cleanup
  • e31aaeb [groovy] Move def to map for jsonslurper
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from yurem as a code owner October 22, 2024 10:58
@dependabot dependabot bot added the java Pull requests that update Java code label Oct 22, 2024
@dependabot dependabot bot requested a review from yuriyz as a code owner October 22, 2024 10:58
@dependabot dependabot bot added the kind-dependencies Pull requests that update a dependency file label Oct 22, 2024
@dependabot dependabot bot requested a review from yuriyzz as a code owner October 22, 2024 10:58
Copy link

dryrunsecurity bot commented Oct 22, 2024

DryRun Security Summary

The provided code change updates the spotbugs-maven-plugin version in the jans-core/pom.xml file from 4.7.3.4 to 4.8.6.5, which is generally a positive change as it indicates the project maintainers are keeping their dependencies up-to-date and addressing potential security vulnerabilities.

Expand for full summary

Summary:

The provided code change is an update to the spotbugs-maven-plugin version in the jans-core/pom.xml file. The previous version 4.7.3.4 has been updated to 4.8.6.5. From an application security perspective, this update is generally a positive change, as it indicates the project maintainers are keeping their dependencies up-to-date and addressing potential security vulnerabilities. SpotBugs is a static code analysis tool that helps identify potential security and quality issues in Java code, so updating to a newer version may provide improved bug detection capabilities.

However, it's important to review the changelog or release notes for the new version to understand any specific security-related improvements or bug fixes that have been included. Additionally, the project maintainers should ensure that the new version of the plugin does not introduce any compatibility issues or regressions in the project's build and deployment processes. Overall, this code change appears to be a routine dependency update that is likely to improve the security and quality of the codebase, and I would recommend approving the pull request, but also suggest that the maintainers review the release notes for the new version to understand any security-related changes.

Files Changed:

  • jans-core/pom.xml: This file has been updated to use the newer version 4.8.6.5 of the spotbugs-maven-plugin, which is a static code analysis tool that helps identify potential security and quality issues in Java code. Updating to a newer version of this plugin is generally a positive change, as it may provide improved bug detection capabilities and address potential security vulnerabilities.

Code Analysis

We ran 9 analyzers against 1 file and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 1 finding

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@moabu
Copy link
Member

moabu commented Nov 7, 2024

@dependabot recreate

…3.4 to 4.8.6.5 in /jans-core

Dependabot couldn't find the original pull request head commit, ef48b4e.
@dependabot dependabot bot force-pushed the dependabot/maven/jans-core/com.github.spotbugs-spotbugs-maven-plugin-4.8.6.5 branch from ef48b4e to 8048936 Compare November 7, 2024 03:33
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 13, 2024

Superseded by #10136.

@dependabot dependabot bot closed this Nov 13, 2024
@dependabot dependabot bot deleted the dependabot/maven/jans-core/com.github.spotbugs-spotbugs-maven-plugin-4.8.6.5 branch November 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant